-
Notifications
You must be signed in to change notification settings - Fork 65
Add analyzers and remove manual assembly attribute #451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds automated assembly attribute generation using code analyzers to replace manual assembly attribute declarations for serialization initialization across multiple extension projects.
- Adds
[SerializationInit]attributes to SerializationInit classes in Teams and SharePoint extensions - Integrates Microsoft.Agents.Core.Analyzers project references to generate assembly attributes automatically
- Removes manual
SerializationInitAssemblyattributes from AssemblyInfo.cs files
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Microsoft.Agents.Extensions.Teams/Serialization/SerializationInit.cs | Added [SerializationInit] attribute to enable analyzer-based assembly attribute generation |
| Microsoft.Agents.Extensions.Teams/Microsoft.Agents.Extensions.Teams.csproj | Added analyzer project reference and debug configuration for generated files |
| Microsoft.Agents.Extensions.Teams/AssemblyInfo.cs | Removed manual SerializationInitAssembly attribute declaration |
| Microsoft.Agents.Extensions.SharePoint/Serialization/SerializationInit.cs | Added [SerializationInit] attribute to enable analyzer-based assembly attribute generation |
| Microsoft.Agents.Extensions.SharePoint/Microsoft.Agents.Extensions.SharePoint.csproj | Added analyzer project reference and debug configuration for generated files |
| Microsoft.Agents.Extensions.SharePoint/AssemblyInfo.cs | Removed manual SerializationInitAssembly attribute declaration |
| Microsoft.Agents.Core/Microsoft.Agents.Core.csproj | Updated analyzer project reference to include PrivateAssets="all" |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...ensions/Microsoft.Agents.Extensions.SharePoint/Microsoft.Agents.Extensions.SharePoint.csproj
Show resolved
Hide resolved
…to users/olstakh/use-analyzer
Use analyzers in the repository to generate
SerializationInitAssemblyattribute for current consumers